This repository was archived by the owner on Feb 11, 2025. It is now read-only.
[FEATURE] Support Speech OpenAI Audio API#24
Open
KaisNeffati wants to merge 2 commits intoai-for-java:mainfrom
Open
[FEATURE] Support Speech OpenAI Audio API#24KaisNeffati wants to merge 2 commits intoai-for-java:mainfrom
KaisNeffati wants to merge 2 commits intoai-for-java:mainfrom
Conversation
fmatar
reviewed
Jun 18, 2024
There was a problem hiding this comment.
Curious about the builder approach. Why not use lombok?
There was a problem hiding this comment.
Why adding another dependency? It's not much that would be saved here in terms of lines of code or complexity. I'd keep as is. @langchain4j @LizeRaes I'd love to use it here: langchain4j/langchain4j#255
Contributor
|
@KaisNeffati thank you and sorry for the delay with the review! @SandraAhlgrimm do you require this PR to move forward with implementing this in LangChain4j? Or do you make your own impl? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces specific support for the speech synthesis feature of the OpenAI Audio API, directly addressing a part of the feature request #20, which was raised on March 12. These changes enable to leverage OpenAI's speech synthesis capabilities, expanding the suite of audio tools.
Key Features Introduced: